fix: guard against state-modifying expressions in range expression
#3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3546 +/- ##
==========================================
- Coverage 89.11% 86.68% -2.43%
==========================================
Files 85 85
Lines 11362 11369 +7
Branches 2584 2586 +2
==========================================
- Hits 10125 9855 -270
- Misses 816 1059 +243
- Partials 421 455 +34
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tserg
changed the title
range expressionrange expression
tserg
commented
Aug 5, 2023
vyper/semantics/analysis/local.py
Outdated
Comment on lines
411
to
416
| disallowed_builtins = ( | ||
| "raw_call", | ||
| "create_minimal_proxy_to", | ||
| "create_copy_of", | ||
| "create_from_blueprint", | ||
| ) |
There was a problem hiding this comment.
I think a better option is to add the is_modifying attribute from member functions to builtins, which would allow us to check both member functions and builtin functions at the same time. Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix #3504, fix #3172, closes #3188.
How I did it
Check for state modifying expressions in a range expression, and validate that no expression modifies state.
How to verify it
See new tests.
Commit message
Description for the changelog
Guard against state-modifying expressions in
rangeexpressionCute Animal Picture